-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remock readme update #64
Open
pphelps28
wants to merge
297
commits into
alexch:master
Choose a base branch
from
BurlingtonCodeAcademy:remock-readme-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remock readme update #64
pphelps28
wants to merge
297
commits into
alexch:master
from
BurlingtonCodeAcademy:remock-readme-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The creative commons CDN has some weird performance problems and randomly takes up to 1second to respond.
These files are requested from Sourcemaps and rewriting the URL causes a 404
* Update installfest * Change min node ver * Update installfest.md
These comments can be computer/host specific and replaced by source maps
* explain why string of 0 is truthy * Add stackoverflow link
* add spacing in counting potatoes section * added potato on counting potato section
* Fix values mukltiline; fix hello express so it works * fix spelling
During the Bundler upgrade process some of the project Gems were upgraded as well.
The depencencies of the project have been brought up to date with the latest supported versions of the packages for the project. Additionally, there were several security vulnerabilites within packages which have been fixed by the updated versions. See the following: Puma - https://snyk.io/vuln/SNYK-RUBY-PUMA-570205 - https://snyk.io/vuln/SNYK-RUBY-PUMA-570206 - GHSA-x7jg-6pwg-fx5h - GHSA-x7jg-6pwg-fx5h Active Support - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-569598 - GHSA-2p68-f74v-9wc6
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-RACK-572377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expanded on a lot of what was already here, as well as adding some concrete stories.
It is now broken it into 2 parts:
1) General design requirements ("Designing Your Site")
2) The stories to complete on top of said design.
I also collapsed the giant list of images at the bottom, for readability's sake.